Allparts Push/Push Poti 500K

YES, this is a good pot.
The quality and the sound of the pot I would say is about on the level with CTS. (IMO) The action and roll-off curve is the same as standard CTS.
The switching works nicely. I use it on an Explorer.
It survived my soldering technique.

It is true that the knob sits a little higher on the guitar even in the lower position. You can try and force the plastic knob a bit further down. The high position of the switch puts the knob about 5-10mm higher from the guitar body. It's not that bad! Try it.
I love the push push switching.

Attention: As someone said it before. Don't pull the knob of the switch when the switch is in the low position. First press the switch to the up position and then take the knob off.

I used this with a set of 4-wire humbuckers as a coil split. They were wired with a 500k pot of the same shaft diameter by default.

Pros:
Quite easy to solder to the tabs
Reliable (the pot didn't gradually get noisy)

Cons:
The fully extended pot sticks out quite far from the body of the guitar
The locking washer is easily shaken loose.
Relatively expensive

Overall it's a good solution if you want to be able to activate the switch without having to grip the pot itself (as with a push-pull equivalent). It's fairly pricey for what it is, but there are few options for push-push pots.

I usually use push pull's on my guitars, but opted for this on my own personal guitar.

This is far faster than push pull, but sometimes a quick push can turn the pot a little, but I'm getting the hang of it.

My next P-P pot will be a boost instead of having foot pedals.

Its time I tried one, works a treat, OK, you cannot see (by looking) if it on or off, but I got all that sorted now simply by listening. Sometime I have to go & listen at my amp, but if we're doing a gig w'out the drummer I can hear my sound from the Mic position and it works well.